fix(metrics): unify Squads webhook failure types into single metric - #149
Open
hash-envy wants to merge 1 commit into
Open
fix(metrics): unify Squads webhook failure types into single metric#149hash-envy wants to merge 1 commit into
hash-envy wants to merge 1 commit into
Conversation
ebatsell
reviewed
Jun 8, 2026
| Err(JitoBellError::Notification( | ||
| "All Squads Slack webhooks failed".to_string(), | ||
| )) | ||
| self.epoch_metrics.increment_squads_webhook_failure(); |
Collaborator
There was a problem hiding this comment.
this metric still looks redundant with webhook_errors incremented above for each error in the response?
Contributor
Author
There was a problem hiding this comment.
Yes. It's because of two consequential decisions
- I made the slack-only squads dispatch BUT I kept the AlertConfig type. This type allows for more than one types of alert channels.
- As such, it is possible to (and at the time i thought maybe we'd want the option) set multiple slack channels for a message. This means that if one of the slack webhooks is down but another is not, 1 error would fire. Not 2. Not 0.
Contributor
Author
There was a problem hiding this comment.
In practice, we'll never hit this path. But i'd rather not silently ignore one of the channels if we set more than one
ebatsell
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.